Skip to content

bug added missing Microsoft Xbox's build targets (using in 2020.3.x and higher) #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug added missing Microsoft Xbox's build targets (using in 2020.3.x and higher) #710

wants to merge 1 commit into from

Conversation

@am1goo
Copy link

@am1goo am1goo commented Jan 11, 2024

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • sign contributor license agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Before changes: after entering in Play mode in Unity Editor, Facebook wrapper produce exception:

ArgumentException: Requested value 'GameCoreScarlett' was not found.
System.Enum+EnumResult.SetFailure (System.Enum+ParseFailureKind failure, System.String failureMessageID, System.Object failureMessageFormatArgument) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.Enum.TryParseEnum (System.Type enumType, System.String value, System.Boolean ignoreCase, System.Enum+EnumResult& parseResult) (at <695d1cc93cca45069c528c15c9fdd749>:0)
System.Enum.Parse (System.Type enumType, System.String value, System.Boolean ignoreCase) (at <695d1cc93cca45069c528c15c9fdd749>:0)
Facebook.Unity.Editor.PlayModeStateChanged.OnPlayModeStateChange (UnityEditor.PlayModeStateChange state) (at <d94eaa45a06f4a28b0b54293a88028d7>:0)
UnityEditor.EditorApplication.Internal_PlayModeStateChanged (UnityEditor.PlayModeStateChange state) (at <25578071f6e44201aac745680e5c8dfc>:0)

After changes: clear log

Test Plan

Test Plan: nothing to test

@am1goo am1goo mentioned this pull request Jan 11, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@am1goo @facebook-github-bot